hide database user info in connection string when it's invalid #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @zijima , thank you for your contribution. I am wondering why you close it? Are you going to submit another one? |
|
The automatic build failed somehow for older go versions i haven't figured out why even after looking at golang source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#131
Description of changes:
If database's username/password is invalid, current sdk cannot stripe password.
The change will handle the error
net/url: invalid userinfofrom url.go and remove the user info part of the DSN.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.