Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.yaml to use the fullname helper #1086

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jibsheet
Copy link

@jibsheet jibsheet commented Apr 9, 2024

Issue

We use this as a subchart with an Alias so it throws errors like this

Error: Deployment.apps "aws-load-balancer-controller" is invalid: spec.template.spec.containers[0].name: Invalid value: "awsLoadBalancerController": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

Description of changes

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Confirmed helm install works locally with our alias and fullnameOverride set

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jibsheet jibsheet marked this pull request as ready for review April 9, 2024 17:51
@jibsheet jibsheet requested a review from M00nF1sh as a code owner April 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant