Add selector to exclude namespace admission controller is deployed in #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewArmstrongVL
approved these changes
Apr 10, 2024
prasadmavuluru
approved these changes
Apr 10, 2024
|
Anybody able to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1088
Description of changes
This PR adds a
namespaceSelectorso the mutating webhook does not run on the namespace the webhook controller is installed in.Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Changes submitted in this PR tested locally against Helm v3 on an EKS 1.27 cluster. After these additions I can delete all pods in the deployment and new pods come back without issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.