Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CNI Metrics Helper helm chart #870

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Release CNI Metrics Helper helm chart #870

merged 1 commit into from
Jan 11, 2023

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Jan 5, 2023

Issue

#155

Description of changes

This PR adds the CNI Metrics Helper chart to eks-charts repo. The chart is synced from here: https://github.com/aws/amazon-vpc-cni-k8s/tree/master/charts/cni-metrics-helper

This is done so that customers can install CNI Metrics Helper from eks-charts repo.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Verified that chart can be installed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdn5126
Copy link
Contributor Author

jdn5126 commented Jan 5, 2023

Holding off on merging this until I can clean up chart a bit

@jdn5126
Copy link
Contributor Author

jdn5126 commented Jan 6, 2023

This PR is waiting to merge until aws/amazon-vpc-cni-k8s#2201 merges

@jdn5126
Copy link
Contributor Author

jdn5126 commented Jan 10, 2023

aws/amazon-vpc-cni-k8s#2201 has merged, so this is just waiting on review

Copy link
Collaborator

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdn5126 jdn5126 removed the request for review from kishorj January 11, 2023 17:39
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdn5126 jdn5126 merged commit a19aef7 into aws:master Jan 11, 2023
@jdn5126 jdn5126 deleted the cni-metrics-helper branch January 11, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants