-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add target_context to dataset columns #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking thought: is target context the only column type that we anticipate being a special case (ie requiring different logic for json parsing)? If we end up having other columns that are similar in behavior to target context, we will want to group these column types together.
Just to double check, is the different logic there because we expect the context to be a list? If so:
|
Interesting. Let's hold off this PR and discuss offline. Maybe we should keep |
Issue #, if available:
Description of changes:
Update: Initially we planned on the
target_context
dataset column taking list of strings. This does not work with ray operations such asmap_batches
due to issues including ray-project/ray#39559 and other unsupported data type errors. Thus thetarget_context
dataset column has been modified to take a string, and we will use string concatenation when there are multiple target contexts, similar to the existingtarget_output
field.Description (updated):
target_context
for evaluation of RAG "ground truth" context provided in a dataset. Thetarget_context
for each dataset sample is alist ofstring.Modifies.json_parser
to accept lists of strings by updating JMESPath output validation and string castingBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.