Skip to content

Commit

Permalink
Merge branch 'main' into automation/yarn-upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
mrgrain authored Aug 29, 2024
2 parents fbad3f7 + 54fa1b2 commit ed434f8
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@jsii/python-runtime/src/jsii/_runtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def implements(*interfaces: Type[Any]) -> Callable[[T], T]:
def deco(cls):
cls.__jsii_type__ = getattr(cls, "__jsii_type__", None)
cls.__jsii_ifaces__ = getattr(cls, "__jsii_ifaces__", []) + list(interfaces)
cls.__jsii_proxy_class__ = lambda: getattr(cls, "__jsii_proxy_class__", None)
cls.__jsii_proxy_class__ = getattr(cls, "__jsii_proxy_class__", lambda: None)

# https://github.com/agronholm/typeguard/issues/479
cls.__protocol_attrs__ = getattr(cls, "__protocol_attrs__", [])
Expand Down
31 changes: 31 additions & 0 deletions packages/@jsii/python-runtime/tests/test_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,37 @@ def test_inheritance_maintained(self):

assert base_names == ["DerivedStruct", "MyFirstStruct"]


class TestImplementsInterface:

def test_jsii_proxy_class_defaults_to_none(self) -> None:
@jsii.implements(IBaz)
class MyBaz:
pass

klass = getattr(MyBaz, "__jsii_proxy_class__")()
assert klass == None

def test_jsii_proxy_class_preserves_user_defined_attribute(self) -> None:

class _MyBazProxy:
def baz_method(self) -> str:
return "_MyBazProxy"

@jsii.implements(IBaz)
class MyBaz:

@staticmethod
def __jsii_proxy_class__():
return _MyBazProxy

def baz_method(self) -> str:
return "MyBaz"

klass = getattr(MyBaz, "__jsii_proxy_class__")()
instance = klass()
assert instance.baz_method() == "_MyBazProxy"

def test_implements_interface(self) -> None:
"""Checks that jsii-generated classes correctly implement the relevant jsii-generated interfaces."""

Expand Down

0 comments on commit ed434f8

Please sign in to comment.