feat(jsii): support aliasing type unions #1807
Conversation
RomainMuller
added
effort/medium
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -795,6 +797,7 @@ export enum TypeKind { | |||
| Class = 'class', | |||
| Enum = 'enum', | |||
| Interface = 'interface', | |||
| NamedUnion = 'union', | |||
There was a problem hiding this comment.
Does this not need an assembly version bump? There will now be assemblies that old version of jsii have no idea what to do with.
| @@ -221,7 +221,7 @@ export class Assembly extends ModuleLike { | |||
| break; | |||
|
|
|||
| default: | |||
| throw new Error('Unknown type kind'); | |||
| throw new Error(`Unsupported type kind: ${typeSpec.kind}`); | |||
|
@RomainMuller Is this something the core team is likely to pick back up anytime soon? Or could this be picked up by an external contributor (possibly myself)? |
|
@jsteinich as I said on Slack - I don't think we're going to be getting to this anytime soon, but I plan to get to it in 2021/2022... Community contributions are always welcome, and I'll be happy to provide pointers & guidances as is necessary if someone wants to take on the challenge. |
|
Discarding as stale. |
RFC: aws/aws-cdk-rfcs#193, aws/aws-cdk-rfcs#194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.