Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dotnet abstract classes should have proxy implementations #241

Merged
merged 4 commits into from
Sep 22, 2018
Merged

fix: dotnet abstract classes should have proxy implementations #241

merged 4 commits into from
Sep 22, 2018

Commits on Sep 21, 2018

  1. fix: dotnet abstract classes should have proxy implementations 

    Abstract classes have can implementations that are not shared thorugh jsii. When trying to instantiate one for these types as a return value, the runtime crashes.
This change creates proxy class types for abstract classes. These types can be instantiated, and have implementations for any methods/properties marked as abstract.

Fixes aws#223
    @costleya
    costleya committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    ad1b15b View commit details
    Browse the repository at this point in the history

  2. test: Add ReturnsAbstract compliance test 

    Add the ReturnsAbstract test to the complaince suite. This test ensures that proxy implementations are returned from methods that return a abstract class or interface.
    @costleya
    costleya committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    795ce88 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. refactor: Address changes for pr 241 

    * Add .DS_Store to .gitignore
* Rename JsiiInterfaceProxyAttribute to JsiiTypeProxy
* Proxy implementations are sealed
* Removed redundant checks for proxy resolution in runtime.

Refactor of aws#241
    @costleya
    costleya committed Sep 22, 2018
    2 Configuration menu
    Copy the full SHA
    bdfe854 View commit details
    Browse the repository at this point in the history

  2. fix: Reverted sln file to resolve build failure 

    Refactor for aws#241
    @costleya
    costleya committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    f708532 View commit details
    Browse the repository at this point in the history