Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update attrs requirement from ~=21.2 to >=21.2,<23.0 in /packages/@jsii/python-runtime #3692

Merged
merged 4 commits into from
Aug 1, 2022
Merged

chore(deps): Update attrs requirement from ~=21.2 to >=21.2,<23.0 in /packages/@jsii/python-runtime #3692

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e88b7a3
chore(deps): Update attrs requirement in /packages/@jsii/python-runtime
dependabot[bot] Aug 1, 2022
80c7ee8
use GITHUB_TOKEN that always exists to post PR comment
RomainMuller Aug 1, 2022
2bdd97c
fix test failing with node 18 due to fs-extra doing something odd wit…
RomainMuller Aug 1, 2022
9f1ea10
remove remaining uses of fs-extra
RomainMuller Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,8 @@ jobs:
name: Run benchmark suite
runs-on: ubuntu-latest
permissions:
contents: write
contents: read
pull-requests: write
needs: build
steps:
# Check out the code
Expand Down Expand Up @@ -395,7 +396,7 @@ jobs:
tool: 'customSmallerIsBetter'
output-file-path: ${{ runner.temp }}/bench-output.json
comment-always: true
github-token: ${{ secrets.PROJEN_GITHUB_TOKEN }}
github-token: ${{ secrets.GITHUB_TOKEN }}
fail-on-alert: true
- name: Upload Benchmark Results
if: github.event_name == 'push'
Expand Down
2 changes: 1 addition & 1 deletion packages/@jsii/python-runtime/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"jsii._embedded.jsii": ["*.js", "*.js.map"],
},
install_requires=[
"attrs~=21.2",
"attrs>=21.2,<23.0",
"cattrs>=1.8,<22.2",
"publication>=0.0.3", # This is used by all generated code.
"typeguard~=2.13.3", # This is used by all generated code.
Expand Down
5 changes: 3 additions & 2 deletions packages/jsii-rosetta/lib/jsii/assemblies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
writeAssembly,
} from '@jsii/spec';
import * as crypto from 'crypto';
import { promises as fsPromises } from 'fs';
import * as fs from 'fs-extra';
import * as path from 'path';

Expand Down Expand Up @@ -367,7 +368,7 @@ async function withDependencies(asm: LoadedAssembly, snippet: TypeScriptSnippet)

compilationDependencies[asm.assembly.name] = {
type: 'concrete',
resolvedDirectory: await fs.realpath(asm.directory),
resolvedDirectory: await fsPromises.realpath(asm.directory),
};

Object.assign(
Expand All @@ -387,7 +388,7 @@ async function withDependencies(asm: LoadedAssembly, snippet: TypeScriptSnippet)
name,
{
type: 'concrete',
resolvedDirectory: await fs.realpath(await findDependencyDirectory(name, asm.directory)),
resolvedDirectory: await fsPromises.realpath(await findDependencyDirectory(name, asm.directory)),
},
] as const,
),
Expand Down