fix(rosetta): python identifiers mishandle identifier translations with capital letters #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th capital letters
mrgrain
approved these changes
Oct 11, 2024
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/aws-cdk#29138
Our python translation currently translates
sizeInMBstosize_in_mbsfor the python examples. However, the actual property is namedsize_in_m_bs. This is because we are currently handling identifiers with the regex[^A-Z][A-Z], which misses theMBpair.I cannot see a use case where we would want to handle identifiers this way (as opposed to interface names ala
IInterface), so I've changed the logic.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.