-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle jsii modules as npm tarballs #52
Commits on Jul 3, 2018
-
Bundle jsii modules as npm tarballs
This change modifies the way we bundle jsii modules. Instead of webpacking them and storing the code inside the assembly spec, we now simply use "npm pack" to produce an npm tarball (.tgz) and include that in the generated library. The kernel now simply accepts the path to the tarball (as oppose to the entire code passed through STDIN), and untars it into a working directory (under node_modules). This effectively allows dependencies to `require(it)`. This change also dramatically improves load-time performance (again, we are not sending a big JSON file over the wire, parse it, and then evaluate it into the VM). Bundled dependencies are now simple npm bundled dependencies. If a module uses the old- style configuration, we fail with instructions. NOTE: we currently do not support multiple versions of the same module loaded together into the same kernel space. This is a major and unacceptable limitation for production environments, which we must address, or otherwise, people will constantly hit these restrictions as jsii software stacks evolve. BREAKING CHANGE.
Elad Ben-Israel committedJul 3, 2018 Configuration menu - View commit details
-
Copy full SHA for d5829ef - Browse repository at this point
Copy the full SHA d5829efView commit details -
Elad Ben-Israel committed
Jul 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 42c0d07 - Browse repository at this point
Copy the full SHA 42c0d07View commit details
Commits on Jul 5, 2018
-
.NET: bundling of jsii-runtime and jsii tarball modules
Bundle jsii tarball modules into generated .NET packages and also bundle the jsii-runtime program as an embedded resource into the dotnet runtime library. This removes the dependency on jsii-runtime, and leaves only node.js as an external dependency. It also improves load-time performance since the tarball is only passed as a path to the runtime/kernel and not the entire .js code.
Elad Ben-Israel committedJul 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 280f5c5 - Browse repository at this point
Copy the full SHA 280f5c5View commit details -
Merge branch 'benisrae/tarballs' into benisrae/dotnet-tarballs
Elad Ben-Israel committedJul 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 7645943 - Browse repository at this point
Copy the full SHA 7645943View commit details -
Bring in a few fixes from dotnet-tarballs
Elad Ben-Israel committedJul 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 031a2c0 - Browse repository at this point
Copy the full SHA 031a2c0View commit details -
Merge branch 'benisrae/tarballs' into benisrae/dotnet-tarballs
Elad Ben-Israel committedJul 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 3678f06 - Browse repository at this point
Copy the full SHA 3678f06View commit details
Commits on Jul 8, 2018
-
Elad Ben-Israel committed
Jul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for 959befd - Browse repository at this point
Copy the full SHA 959befdView commit details -
`set -euo` fails for unbound variables
Elad Ben-Israel committedJul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for c05c9b1 - Browse repository at this point
Copy the full SHA c05c9b1View commit details -
Elad Ben-Israel committed
Jul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for 13ff227 - Browse repository at this point
Copy the full SHA 13ff227View commit details -
Merge branch 'benisrae/fix-update-version' into benisrae/dotnet-tarballs
Elad Ben-Israel committedJul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for 84ef674 - Browse repository at this point
Copy the full SHA 84ef674View commit details -
Merge branch 'benisrae/fix-update-version' into benisrae/tarballs
Elad Ben-Israel committedJul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for b9d3149 - Browse repository at this point
Copy the full SHA b9d3149View commit details -
Add missing tgz to pacmak tests
Elad Ben-Israel committedJul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for d6f5e0d - Browse repository at this point
Copy the full SHA d6f5e0dView commit details -
Ignore +build when setting jsii version
Elad Ben-Israel committedJul 8, 2018 Configuration menu - View commit details
-
Copy full SHA for d04f0b9 - Browse repository at this point
Copy the full SHA d04f0b9View commit details
Commits on Jul 9, 2018
-
Elad Ben-Israel committed
Jul 9, 2018 Configuration menu - View commit details
-
Copy full SHA for 0c2e631 - Browse repository at this point
Copy the full SHA 0c2e631View commit details -
Elad Ben-Israel committed
Jul 9, 2018 Configuration menu - View commit details
-
Copy full SHA for e862a4a - Browse repository at this point
Copy the full SHA e862a4aView commit details
Commits on Jul 10, 2018
-
Do not include commit sha in version
Since we have version numbers in test expectations every build will get a different version number and that invariably causes tests to fail.
Elad Ben-Israel committedJul 10, 2018 Configuration menu - View commit details
-
Copy full SHA for ff76775 - Browse repository at this point
Copy the full SHA ff76775View commit details
Commits on Jul 11, 2018
-
1. Add calc-lib 2. Create expected tarball on-the-fly to avoid binary diffs resulting from different platforms
Elad Ben-Israel committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 0efe687 - Browse repository at this point
Copy the full SHA 0efe687View commit details -
Take only first 7 chars from commit sha
Elad Ben-Israel committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 0109d7c - Browse repository at this point
Copy the full SHA 0109d7cView commit details -
Merge branch 'benisrae/dotnet-tarballs' into benisrae/tarballs
Elad Ben-Israel committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for e358e35 - Browse repository at this point
Copy the full SHA e358e35View commit details -
Merge remote-tracking branch 'origin/master' into benisrae/tarballs
Elad Ben-Israel committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 6672bc2 - Browse repository at this point
Copy the full SHA 6672bc2View commit details -
Add node_modules/.bin to PATH so we can execute lerna
Elad Ben-Israel committedJul 11, 2018 1Configuration menu - View commit details
-
Copy full SHA for 05540b7 - Browse repository at this point
Copy the full SHA 05540b7View commit details -
Elad Ben-Israel committed
Jul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 817c11b - Browse repository at this point
Copy the full SHA 817c11bView commit details