Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint to avoid error #1821

Merged
merged 2 commits into from
May 17, 2022
Merged

Upgrade golangci-lint to avoid error #1821

merged 2 commits into from
May 17, 2022

Conversation

spring1843
Copy link
Contributor

@spring1843 spring1843 commented May 17, 2022

1. Issue, if available:

V/w/w/k/karpenter (providerCrd) [127]> golangci-lint run
ERRO [runner] Panic: buildir: package "lo" (isInitialPkg: false, needAnalyzeSource: true): T: goroutine 12608 [running]:

2. Description of changes:

Fixes the above error that has started showing up. Looks like we need to upgrade.
golangci/golangci-lint#2664

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…gci.yaml to avoid error introduced after introduction of generics.
@spring1843 spring1843 requested a review from a team as a code owner May 17, 2022 20:43
@spring1843 spring1843 requested a review from suket22 May 17, 2022 20:43
@netlify
Copy link

netlify bot commented May 17, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8779b76
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62840913c3d0e80008a641d7

suket22
suket22 previously approved these changes May 17, 2022
@spring1843 spring1843 merged commit 3dc02a4 into aws:main May 17, 2022
@spring1843 spring1843 deleted the rm/fix-golint-1.18 branch May 17, 2022 22:07
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants