chore: Add prometheus metrics for AWS client calls #6421

jonathan-innis · 2024-06-27T21:02:46Z

Fixes #N/A

Description

Add Prometheus metrics for the AWS SDK Go. This used https://github.com/jonathan-innis/aws-sdk-go-prometheus to hydrate client-side metrics into the AWS SDK Go calls until the upstream aws-sdk-go or aws-sdk-go-v2 support metrics out-of-the box.

See: aws/aws-sdk-go-v2#1744

# HELP aws_sdk_go_request_total The total number of AWS SDK Go requests
# TYPE aws_sdk_go_request_total counter
aws_sdk_go_request_total{action="CreateFleet",code="200",service="EC2"} 12
aws_sdk_go_request_total{action="CreateLaunchTemplate",code="200",service="EC2"} 48
aws_sdk_go_request_total{action="CreateTags",code="200",service="EC2"} 24
aws_sdk_go_request_total{action="DeleteLaunchTemplate",code="200",service="EC2"} 24
aws_sdk_go_request_total{action="DeleteMessage",code="200",service="SQS"} 89
aws_sdk_go_request_total{action="DescribeCluster",code="200",service="EKS"} 1
aws_sdk_go_request_total{action="DescribeImages",code="200",service="EC2"} 27
aws_sdk_go_request_total{action="DescribeInstanceTypeOfferings",code="200",service="EC2"} 3
aws_sdk_go_request_total{action="DescribeInstanceTypes",code="200",service="EC2"} 8
aws_sdk_go_request_total{action="DescribeInstanceTypes",code="412",service="EC2"} 1
aws_sdk_go_request_total{action="DescribeInstances",code="200",service="EC2"} 356
aws_sdk_go_request_total{action="DescribeInstances",code="400",service="EC2"} 13
aws_sdk_go_request_total{action="DescribeLaunchTemplates",code="200",service="EC2"} 1
aws_sdk_go_request_total{action="DescribeLaunchTemplates",code="400",service="EC2"} 48
aws_sdk_go_request_total{action="DescribeSecurityGroups",code="200",service="EC2"} 27
aws_sdk_go_request_total{action="DescribeSpotPriceHistory",code="200",service="EC2"} 3
aws_sdk_go_request_total{action="DescribeSubnets",code="200",service="EC2"} 27
aws_sdk_go_request_total{action="GetInstanceProfile",code="200",service="IAM"} 58
aws_sdk_go_request_total{action="GetParameter",code="200",service="SSM"} 108
aws_sdk_go_request_total{action="GetProducts",code="200",service="Pricing"} 9
aws_sdk_go_request_total{action="GetQueueUrl",code="200",service="SQS"} 1
aws_sdk_go_request_total{action="ReceiveMessage",code="200",service="SQS"} 133
aws_sdk_go_request_total{action="TerminateInstances",code="200",service="EC2"} 5
100 2624k    0 2624k    0     0  6147k      0 --:--:-- --:--:-- --:--:-- 6160k

How was this change tested?

Deploying Prometheus and the updated version with these prometheus metrics to my cluster and validating that they are returned on the prometheus metrics endpoint

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-06-27T21:03:01Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`a5e2113`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/667f581ef1cc140008a84b05

coveralls · 2024-06-27T21:07:22Z

Pull Request Test Coverage Report for Build 9703555317

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.111%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	2	0.0%

Totals
Change from base Build 9691760501:	0.0%
Covered Lines:	5787
Relevant Lines:	7315

💛 - Coveralls

coveralls · 2024-06-27T22:15:10Z

Pull Request Test Coverage Report for Build 9704275993

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 79.171%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/webhooks/webhooks.go	3	0.0%

Totals
Change from base Build 9704271327:	0.01%
Covered Lines:	5785
Relevant Lines:	7307

💛 - Coveralls

coveralls · 2024-06-27T22:15:41Z

Pull Request Test Coverage Report for Build 9704280294

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 79.157%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/webhooks/webhooks.go	3	0.0%

Totals
Change from base Build 9704271327:	0.0%
Covered Lines:	5784
Relevant Lines:	7307

💛 - Coveralls

jonathan-innis

/karpenter snapshot

coveralls · 2024-06-27T22:17:46Z

Pull Request Test Coverage Report for Build 9704318474

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 79.171%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	2	0.0%

Totals
Change from base Build 9704271327:	0.01%
Covered Lines:	5785
Relevant Lines:	7307

💛 - Coveralls

github-actions · 2024-06-27T22:20:50Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4fb047386122c42c021c401c3386b885c26def90.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4fb047386122c42c021c401c3386b885c26def90" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/operator/operator.go

coveralls · 2024-06-29T00:43:20Z

Pull Request Test Coverage Report for Build 9720156565

Details

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 78.337%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/operator/operator.go	7	9.26%

Totals
Change from base Build 9720043516:	0.0%
Covered Lines:	5786
Relevant Lines:	7386

💛 - Coveralls

engedaam

LGTM 🚀

coveralls · 2024-06-29T00:44:14Z

Pull Request Test Coverage Report for Build 9720163627

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 78.324%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/operator/operator.go	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.56%

Totals
Change from base Build 9720043516:	-0.01%
Covered Lines:	5785
Relevant Lines:	7386

💛 - Coveralls

jonathan-innis requested a review from a team as a code owner June 27, 2024 21:02

jonathan-innis requested a review from jigisha620 June 27, 2024 21:02

jonathan-innis force-pushed the add-aws-sdk-go-metrics branch 3 times, most recently from 6fc1627 to 4fb0473 Compare June 27, 2024 22:14

jonathan-innis commented Jun 27, 2024

View reviewed changes

jonathan-innis enabled auto-merge (squash) June 27, 2024 22:49

engedaam reviewed Jun 28, 2024

View reviewed changes

pkg/operator/operator.go Show resolved Hide resolved

jonathan-innis force-pushed the add-aws-sdk-go-metrics branch from 4fb0473 to 799835c Compare June 29, 2024 00:40

Add prometheus metrics for AWS client calls

a5e2113

jonathan-innis force-pushed the add-aws-sdk-go-metrics branch from 799835c to a5e2113 Compare June 29, 2024 00:41

engedaam approved these changes Jun 29, 2024

View reviewed changes

jonathan-innis merged commit 401c0f9 into aws:main Jun 29, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add prometheus metrics for AWS client calls #6421

chore: Add prometheus metrics for AWS client calls #6421

jonathan-innis commented Jun 27, 2024 •

edited

Loading

netlify bot commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

jonathan-innis left a comment

coveralls commented Jun 27, 2024 •

edited

Loading

github-actions bot commented Jun 27, 2024

coveralls commented Jun 29, 2024 •

edited

Loading

engedaam left a comment

coveralls commented Jun 29, 2024 •

edited

Loading

chore: Add prometheus metrics for AWS client calls #6421

chore: Add prometheus metrics for AWS client calls #6421

Conversation

jonathan-innis commented Jun 27, 2024 • edited Loading

netlify bot commented Jun 27, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9703555317

Details

💛 - Coveralls

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9704275993

Details

💛 - Coveralls

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9704280294

Details

💛 - Coveralls

jonathan-innis left a comment

Choose a reason for hiding this comment

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9704318474

Details

💛 - Coveralls

github-actions bot commented Jun 27, 2024

coveralls commented Jun 29, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9720156565

Details

💛 - Coveralls

engedaam left a comment

Choose a reason for hiding this comment

coveralls commented Jun 29, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9720163627

Details

💛 - Coveralls

jonathan-innis commented Jun 27, 2024 •

edited

Loading

netlify bot commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 29, 2024 •

edited

Loading

coveralls commented Jun 29, 2024 •

edited

Loading