Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix setting references in notes about RESERVED_ENI #6896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orirawlings
Copy link
Contributor

@orirawlings orirawlings commented Aug 29, 2024

Fixes #N/A

Description

ConfigMap based global settings are no longer supported and the current links are broken.

I'm new to contributing doc website changes. I know the contribution guides discuss making changes under website/content/en/preview/ only, but this fix needs to be back-ported to all the current versions, which are all inaccurate and have broken links. I've included changes to the existing versions in this PR, but can back those out if necessary. Please advise.

How was this change tested?

Inspecting the generated site locally with hugo server.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ConfigMap based global settings are no longer supported and the current
links are broken.
@orirawlings orirawlings requested a review from a team as a code owner August 29, 2024 19:59
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0374791
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66d0d3213259660008ae0caf
😎 Deploy Preview https://deploy-preview-6896--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@orirawlings
Copy link
Contributor Author

Oh no. Don't stale me. ☺️

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@orirawlings
Copy link
Contributor Author

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant