Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the scheduler to be updated #7045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stijndehaes
Copy link
Contributor

Fixes #N/A

Description

This change allows the scheduler for the karpenter pods to be changed.
This is usefull when using a custom scheduler, when mixing 2 different schedulers you might run into issues with priority and preemption (one scheduler deleting a pod to make room for Karpenter, but the other scheduler quickly schedules a new pod because there is room).

How was this change tested?

Copy of the helm chart applied locally

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

It updates the helm chart docs, but not the karpenter docs. They have been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stijndehaes stijndehaes requested a review from a team as a code owner September 20, 2024 12:07
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7af038c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ed65693fb86f00085321df

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10958923846

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.995%

Totals Coverage Status
Change from base Build 10910984774: 0.0%
Covered Lines: 5520
Relevant Lines: 6651

💛 - Coveralls

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one issue in the values.yaml

@@ -60,6 +60,8 @@ hostNetwork: false
dnsPolicy: ClusterFirst
# -- Configure DNS Config for the pod
dnsConfig: {}
# -- Override the default scheduler
schedulerName: """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schedulerName: """
schedulerName: ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants