Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: implementing observability around usage of deprecated amis #7145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shabbskagalwala
Copy link
Contributor

Fixes #N/A

Description

This is an RFC for implementing observability around usage of deprecated AMIs that was implemented with #6500

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit bae0ae3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fcc68322910800083cc48a

conditions:
- lastTransitionTime: "2024-09-09T04:32:55Z"
message: AMISelector matched deprecated AMIs ami-054c1b6d4be926123, ami-0d20e6af81d7ce999
reason: AMIsDeprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the option to add this as it's own type? Also can we add more information on the observability piece that we get by using status conditions?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11137634594

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 83.326%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11134190742: -0.03%
Covered Lines: 5572
Relevant Lines: 6687

💛 - Coveralls

@engedaam engedaam self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants