Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify s2nd/c to do serialization/deserialization #4533

Merged
merged 9 commits into from
May 7, 2024

Conversation

maddeleine
Copy link
Contributor

Resolved issues:

N/A

Description of changes:

I'm writing an integ test to check that a serialized connection can be deserialized by an older s2n-tls version and vice versa. These are the changes that are required to do this.

Call-outs:

Ordinarily, I would include the integ test with this PR. However, this PR has to get merged before so that the mainline version includes the option to serialize. Currently mainline s2nd/c doesn't recognize the serialize CLI options yet. To see a preview of what the serialization test will look like, see my fork.

Testing:

Manual testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label May 1, 2024
bin/common.c Outdated Show resolved Hide resolved
bin/s2nc.c Outdated Show resolved Hide resolved
@maddeleine maddeleine requested a review from lrstewart May 2, 2024 22:51
bin/s2nc.c Outdated Show resolved Hide resolved
bin/common.h Outdated Show resolved Hide resolved
bin/common.c Outdated Show resolved Hide resolved
bin/common.c Outdated Show resolved Hide resolved
bin/s2nd.c Outdated Show resolved Hide resolved
bin/s2nc.c Outdated Show resolved Hide resolved
bin/common.h Show resolved Hide resolved
bin/s2nc.c Outdated Show resolved Hide resolved
bin/common.h Outdated Show resolved Hide resolved
@maddeleine maddeleine requested a review from lrstewart May 7, 2024 18:17
@maddeleine maddeleine merged commit 4862e7f into main May 7, 2024
36 checks passed
@maddeleine maddeleine deleted the backward_compat branch May 7, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants