-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: kTLS specific nix devShell #4886
Open
dougch
wants to merge
15
commits into
aws:main
Choose a base branch
from
dougch:ktls_goes_brrrr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
force-pushed
the
ktls_goes_brrrr
branch
from
November 12, 2024 01:09
371a8fb
to
35a4213
Compare
lrstewart
reviewed
Nov 12, 2024
lrstewart
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
n/a
Description of changes:
We're running our kTLS tests under qemu without acceleration, which take over an hour. This change creates a minimal nix devShell with no python, corretto, aws-lc, etc.
High level timing currently:
(current PR) Running all unit tests with this minimal devShell takes 49 minutes. This effectively eliminates the devshell timing from above.
Call-outs:
Other options:
unit ktls
drops the runtime to 38 minutes.Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally; Codebuild
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.