PaginationTrait Support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
paginators
branch
4 times, most recently
from
233d4b9
to
96140bd
Compare
jasdel
reviewed
Nov 10, 2020
There was a problem hiding this comment.
Changes look good, but had two main comments:
1.) We probably want the nextToken member to be the member symbol of the API model. This complicates checking for empty string, but that's solvable by special casing string to check for empty string, and nil for everything else. My work with the dense list map change uses a helper, that regretfully isn't available here yet that would simplify this.
2.) The done member being able to reactivate is odd, i think. If the SDK detects end of pagination, for any reason, the paginator should forcibly stop there. Arguably it probably should also return an error if it is called when it is known that there are no more pages.
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
skmcgrail
force-pushed
the
paginators
branch
from
96140bd
to
48a464f
Compare
jasdel
suggested changes
Nov 12, 2020
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
...mithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Paginators.java
Outdated
Show resolved
Hide resolved
jasdel
approved these changes
Nov 12, 2020
skmcgrail
force-pushed
the
paginators
branch
from
92a1be5
to
31115b5
Compare
skmcgrail
force-pushed
the
paginators
branch
from
31115b5
to
b3193dc
Compare
jasdel
reviewed
Nov 17, 2020
skmcgrail
force-pushed
the
paginators
branch
from
76246a5
to
ac873c1
Compare
skmcgrail
force-pushed
the
paginators
branch
from
ac873c1
to
75ce021
Compare
skmcgrail
force-pushed
the
paginators
branch
from
75ce021
to
54de852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on smithy-lang/smithy#628