codegen: middleware snapshot tests #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Feb 22, 2024
| )); | ||
| } | ||
|
|
||
| private GoWriter.Writable testCheckSnapshot(OperationShape operation, SymbolProvider symbolProvider) { |
There was a problem hiding this comment.
One question, if a user want to test an op's stack snapshot, does he need to add updateSnapshot and testSnapshot into APIOptions in order?
There was a problem hiding this comment.
No, none of this is user-facing. The generated test code handles calling these functions for us.
syall
approved these changes
Feb 22, 2024
| return err | ||
| } | ||
| if actual := stack.String(); actual != string(expected) { | ||
| return fmt.Errorf("%s != %s", expected, actual) |
There was a problem hiding this comment.
I think it'd be better to use a dedicated diff tool, but that can be an incremental improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds codegen integration to generate middleware snapshot tests.
Other minor things