add codegen support for string array and operation context params in endpoint bindings #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Jun 25, 2024
| } | ||
|
|
||
| private Result visit(JmespathExpression expr, Shape current) { | ||
| if (expr instanceof FunctionExpression) { |
There was a problem hiding this comment.
[nit] Since Java 17 you can do
if (expr instanceof FunctionExpression fexpr) {
// look ma, typecasting is already done
return visitFunction(fexpr, current)
}
[also nit, but tangential] if we could switch to Java 21 we could even do Pattern Matching and do something like
return switch (expr) {
case FunctionExpression fexpr -> return visitFunction(fexpr, current);
....
}
| * trying to recursively compose/organize Writable templates. | ||
| */ | ||
| @SmithyInternalApi | ||
| public class GoJmespathExpressionGenerator { |
There was a problem hiding this comment.
We should really have tests for this class
| var lookahead = new GoJmespathExpressionGenerator(ctx, new GoWriter(""), leftMember, expr.getRight()) | ||
| .generate("v"); | ||
|
|
||
| ++idIndex; |
There was a problem hiding this comment.
not quite sure I follow why we increase the index when visiting the projection. Each field increases the index because we're visiting a concrete field, but why do we increase it here?
There was a problem hiding this comment.
We need a new identifier for the slice variable that holds the result of the overall projection (it's declared in the following write()).
| return new Result(listOf(STRING_SHAPE), "v" + idIndex); | ||
| } | ||
|
|
||
| public record Result(Shape shape, String ident) {} |
wty-Bryant
approved these changes
Jun 25, 2024
Madrigal
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoCodegenContextfield toCodegenVisitorand pass it down. This context object contains a handful of principal codegen resources which everything generally needs, and passing it simplifies a lot of constructor calls (observe the difference inOperationGenerator. This matches the newDirectedCodegenpattern.