Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading typo in SNAT explanation #53

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Commits on Aug 26, 2019

  1. Fix misleading typo

    My understanding is that the edited sentence only makes sense with the proposed change. A node does not know about its public IP, private to public NAT happens on the InternetGateways. Also, nodes can only have a single public IP, a single primary private IP, and many secondary private IPs. So it doesn't make sense to talk about a 'primary public IP', but it is meaningful to say 'primary private IP'.
    
    Unfortunately, the attached image is also misleading, as it shows a private to public SNAT done by the CNI plugin, whereas it is a SNAT between a secondary private to the primary private address. The primary private to public SNAT happens on the gateway, this could be also shown.
    Tamas Kornai authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    2519c6b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Configuration menu
    Copy the full SHA
    57d2bbe View commit details
    Browse the repository at this point in the history