Merge pull request #298 from kzys/apple-fix

Run "make all-variants" only if Go >= 1.16

.github/workflows/build.yaml

@@ -27,5 +27,14 @@ jobs:
         with:
           go-version: ${{ matrix.go }}
       - run: make get-deps
-      - run: make all-variants
+
+      # Apple Silicon is not supported by Go < 1.16.
+      # https://go.dev/blog/go1.16
+      - name: Cross-compile all variants
+        run: make all-variants
+        if: ${{ matrix.go >= '1.16' }}
+      - name: Cross-compile all variants except for Apple Silicon
+        run: make linux-amd64 linux-arm64 darwin-amd64 windows-amd64
+        if: ${{ matrix.go < '1.16' }}
+
       - run: make test

scripts/build_binary.sh

@@ -12,6 +12,8 @@
 # ANY KIND, either express or implied. See the License for the specific
 # language governing permissions and limitations under the License.
 
+set -euo pipefail
+
 # Normalize to working directory being build root (up one level from ./scripts)
 ROOT=$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." && pwd )
 cd "${ROOT}"
@@ -32,7 +34,7 @@ if [[ -n "${3}" ]]; then
   version_ldflags="$version_ldflags -X ${package_root}/version.GitCommitSHA=${3}"
 fi
 
-GOOS=$TARGET_GOOS GOARCH=$TARGET_GOARCH CGO_ENABLED=0 \
+GOOS=${TARGET_GOOS:-} GOARCH=${TARGET_GOARCH:-} CGO_ENABLED=0 \
        	go build -installsuffix cgo -a -ldflags "-s ${version_ldflags}" \
        	-o ../$1/docker-credential-ecr-login \
 	./cli/docker-credential-ecr-login

scripts/build_variant.sh

@@ -12,6 +12,8 @@
 # ANY KIND, either express or implied. See the License for the specific
 # language governing permissions and limitations under the License.
 
+set -euo pipefail
+
 # This script is used for compilation of a specific variant.
 # Specify GOOS as $1, GOARCH as $2
 # Binaries are placed into ./bin/$GOOS-$GOARCH/docker-credential-ecr-login