Make expiration logic more readable #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good! 🚢 I don't know what I was thinking when I wrote that original function. Bug looks fixed and code is much more understandable now. Thanks again @f-barth for brining this to our attention! |
|
When will this be able to get merged? Im actually running into this issue now... |
samuelkarp
force-pushed
the
readable-expiry
branch
from
076e2bb
to
1614bf0
Compare
|
@roastlechon I've just merged it, please let us know if you still run into problems. |
|
@samuelkarp Thanks! It works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This carries #8 from @f-barth and attempts to make the logic more readable.
r? @sentientmonkey