Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding a config section for the helper #272

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

callum-tait-pbx
Copy link
Contributor

@callum-tait-pbx callum-tait-pbx commented Mar 31, 2021

Description of changes:

I was looking for config around caching and found this feature. It's a shame that the configuration options around the tool itself aren't documented and so I've made this PR as it wasn't that easy to find when you don't know its there.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@callum-tait-pbx callum-tait-pbx changed the title docs: Adding a config section for the helper docs: adding a config section for the helper Mar 31, 2021
@kzys
Copy link
Contributor

kzys commented May 21, 2021

The change looks good! Can you squash the commits into one commit?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Documenting the toggle feature added in PR 3, 192a492
@callum-tait-pbx
Copy link
Contributor Author

callum-tait-pbx commented May 22, 2021

Rebased, thank you very much for this tool! It has been instrumental in my environment!

I did have a comment on 1 of the review comments, if I've misunderstood however feel free to merge!

@callum-tait-pbx
Copy link
Contributor Author

I think this is mergable now?

@samuelkarp samuelkarp requested a review from kzys May 27, 2021 17:13
@kzys kzys merged commit 42cd54a into awslabs:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants