Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go build flags to ensure reproducible builds #304

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Add go build flags to ensure reproducible builds #304

merged 1 commit into from
Mar 24, 2022

Conversation

wszaranski
Copy link
Contributor

Issue #, if available:
Produce reproducible builds #186

Description of changes:
Adds -trimpath to remove local paths from executable and sets build id to empty string using -ldflags=-buildid=. Both flags are required for reproducible builds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds `-trimpath` to remove local paths from executable and sets build id
to empty string using `-ldflags=-buildid=`. Both flags are required for
reproducible builds.
Copy link
Contributor

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 7a06d24 into awslabs:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants