change make docker
to copy from finished container instead of mounting
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
make docker
works by mounting the output dir on the host into the build container.This means it can't be used when the build environment is itself a docker container.
This PR changes the docker build behaviour to instead run the build container without mounting, and then copying the binary out of the finished container before removing it.
Benefits:
Drawbacks:
make docker
builds from scratch every time (if this is an issue it could be worked around with the drawback of more complexity in the Makefile)