Introduce CloudFront secure headers [blocked - don't merge] #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @with_logging | ||
| @helper.delete | ||
| def delete(event, context): | ||
| return None |
There was a problem hiding this comment.
should we not clean it up too?
There was a problem hiding this comment.
lol read the PR description ^
There was a problem hiding this comment.
Actually, you mightn't be able to delete it anyway.. I don't know if this has changed since 2017 but: hashicorp/terraform-provider-aws#1721
matteofigus
commented
Mar 19, 2020
| response = event['Records'][0]['cf']['response'] | ||
| h = response['headers'] | ||
| h['strict-transport-security'] = [{ 'key': 'Strict-Transport-Security', 'value': 'max-age=63072000; includeSubdomains; preload'}] | ||
| h['content-security-policy'] = [{ 'key': 'Content-Security-Policy', 'value': "default-src 'none'; img-src 'self'; script-src 'self'; style-src 'self'; object-src 'none'"}] |
There was a problem hiding this comment.
Note this is a sample header, in case, I need to work out the right combination to ensure the website works (whitelist here all the dependencies such as the cognito, glue and s3 urls).
matteofigus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR as incomplete (no tests and docs yet) because I wanted to show some progress and discuss some items.
Before this approach I tried:
Another idea I didn't try was to spin API Gateway with CF backed release on top of S3?
Things I didn't like about this approach (which is still the simplest and doesn't require using new services):
If we are ok, I can add tests and clean this up, or we can just close.
Another thing, should we make this optional?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.