Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#33): revert npm install on multi-container-arch to resolve cd issue #34

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix(#33): revert npm install on multi-container-arch to resolve cd issue #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9caa750
fix(#33): revert npm install on multi-container-arch to resolve cd issue
scrthq Feb 1, 2024
04753bb
chore: move npm install to same layer
scrthq Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,10 @@ COPY . /ash/
#
# Install CDK Nag stub dependencies
#
RUN cd /ash/utils/cdk-nag-scan && \
npm install
# Update NPM to latest
RUN npm install -g npm && \
cd /ash/utils/cdk-nag-scan && \
npm install --quiet

#
# Flag ASH as local execution mode since we are running in a container already
Expand Down
3 changes: 0 additions & 3 deletions helper_dockerfiles/Dockerfile-cdk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ RUN mkdir -p /src && \
mkdir -p /run/scan/src \
mkdir -p /ash

RUN cd /utils/cdk-nag-scan && \
npm install

WORKDIR /src

CMD bash -C /utils/cdk-docker-execute.sh
2 changes: 1 addition & 1 deletion utils/cdk-docker-execute.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ cd ${CDK_WORK_DIR}

# # Install the CDK application's required packages

# npm install --quiet
npm install --silent

#
# Now, for each file, run a cdk synth to subject the file to CDK-NAG scanning
Expand Down
Loading