improve error message with invalid spill bucket #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymai
approved these changes
Oct 24, 2022
hackett123
approved these changes
Oct 24, 2022
akuzin1
added a commit
that referenced
this pull request
Nov 4, 2022
Feature/db2 connector (#796) Add CompositeHandler parameter to CF template (#821) Add support for optional LambdaRole parameter for AthenaSynapseConnector (#808) Added Schema name condition in COUNT_RECORDS_QUERY DDBPredicateUtils: Fix bug with predicate generation AWS Signer set empty content (#814) BlockUtils ClassCastException (#813) Improve error message with invalid spill bucket (#812) Don't catch just to rethrow ValuesGenerator: fix String:getBytes() issue
akuzin1
added a commit
that referenced
this pull request
Nov 4, 2022
Add CompositeHandler parameter to CF template (#821) Add support for optional LambdaRole parameter for AthenaSynapseConnector (#808) Added Schema name condition in COUNT_RECORDS_QUERY DDBPredicateUtils: Fix bug with predicate generation AWS Signer set empty content (#814) BlockUtils ClassCastException (#813) Improve error message with invalid spill bucket (#812) Don't catch just to rethrow ValuesGenerator: fix String:getBytes() issue
akuzin1
added a commit
that referenced
this pull request
Nov 4, 2022
Add CompositeHandler parameter to CF template (#821) Add support for optional LambdaRole parameter for AthenaSynapseConnector (#808) Added Schema name condition in COUNT_RECORDS_QUERY DDBPredicateUtils: Fix bug with predicate generation AWS Signer set empty content (#814) BlockUtils ClassCastException (#813) improve error message with invalid spill bucket (#812) Don't catch just to rethrow ValuesGenerator: fix String:getBytes() issue
henrymai
pushed a commit
that referenced
this pull request
Nov 4, 2022
Add CompositeHandler parameter to CF template (#821) Add support for optional LambdaRole parameter for AthenaSynapseConnector (#808) Added Schema name condition in COUNT_RECORDS_QUERY DDBPredicateUtils: Fix bug with predicate generation AWS Signer set empty content (#814) BlockUtils ClassCastException (#813) improve error message with invalid spill bucket (#812) Don't catch just to rethrow ValuesGenerator: fix String:getBytes() issue
slomkarafa
added a commit
to slomkarafa/aws-athena-query-federation
that referenced
this pull request
Nov 7, 2022
* Setup Deltalake module from Example * First version using Delta Standalone reader * WIP: Remove DeltaStandalone dependency and all Scala dependencies * [DeltaLake] First working tested version * Clean ParquetConverter * Add tests * Update README and tests * [Deltalake] Add predicate pushdown for getSplits * [Deltalake] Add support for Decimal in Fixed_len_byte_array * [Deltalake] Optimize Splits with getPartitions + add parquet projection * [Deltalake] Fix MetaData partitionColumn parsing * [Deltalake] Minor cleaning * WIP-0 * update * Update pom.xml * Fix the wrong jar name in tools/validate_connector.sh (awslabs#799) * Fix wrong jar name in /tools/validate_connector.sh Authored-by: jiajie <[email protected]> * athena-docdb: add disable_projection_and_casing env var Add the ability to disable projections and casing in order to support querying docdb with mixed casing column names. To enable, set the "disable_projection_and_casing" environment variable on the athena-docdb lambda to "true" * athena-docdb: Make use of the Glue table property "sourceTable" This is needed when users have mixed casing in their table names. * Modified partitioning logic in snowflake * Modified partitioning logic in snowflake connector * Addressed review comments * Cut release v2022.42.1 Modified partitioning logic in snowflake athena-docdb: Make use of the Glue table property "sourceTable" athena-docdb: add disable_projection_and_casing env var Fix the wrong jar name in tools/validate_connector.sh (awslabs#799) Update pom.xml athena-dynamodb: Fix issue with the Condition in FunctionRole Add support for optional LambdaRole parameter for AthenaDynamoDBConnector Add generative tests for the default FieldResolver as well Data Integrity: Add generative tests for DynamoDb and Elasticsearch. * athena-cloudwatch: fix athena-cloudwatch.yaml * Cut release v2022.42.2 athena-cloudwatch: fix athena-cloudwatch.yaml * ValuesGenerator: fix String:getBytes() issue Different JDKs have different internal representations of Strings. When the JDK has a non UTF8 representation (like UTF16), these tests were setting invalid byte values for Arrow string fields/values which are expecting UTF8 encoded bytes. This was causing test failures because it caused keys that were expected to be unique to not be unique since invalid UTF8 strings can be considered equal (UTF16 can't just be casted to UTF8). The fix here is to make sure that we use getBytes(StandardCharsets.UTF_8) to ensure that we get the byte encoding that we want. * seems to work * Don't catch just to rethrow There are several instances in the code where we caught an exception just to rethrow it as a RuntimeException. Sometimes this was due to the interfaces not declaring that they throw, so the implementations were forced to catch exceptions and then rethrow them as RuntimeExceptions. This patch fixes the interfaces and implementations that inherit from those interfaces to not catch just to rethrow. * improve error message with invalid spill bucket (awslabs#812) * improve error message with invalid spill bucket * BlockUtils ClassCastException (awslabs#813) Fix for ClassCastException * AWS Signer set empty content (awslabs#814) * Fix AwsRequestSigning bug for empty body * DDBPredicateUtils: Fix bug with predicate generation Checks were removed with a prior change that should have still been there. Added tests to prevent regressions again in the future. * Added Schema name condition in COUNT_RECORDS_QUERY * Add support for optional LambdaRole parameter for AthenaSynapseConnector (awslabs#808) * Add support for optional LambdaRoleARN and optional PermissionsBoundaryARN parameters for AthenaSynapseConnector * Add CompositeHandler parameter to CF template (awslabs#821) * WIP checkpoint * refactored * athena-postgresql: Set default CompositeHandler This is to maintain backwards compatibility. * Feature/db2 connector (awslabs#796) DB2 Connector * merge Co-authored-by: Marc ALONSO <[email protected]> Co-authored-by: rafalslo <[email protected]> Co-authored-by: mik-patient <[email protected]> Co-authored-by: J <[email protected]> Co-authored-by: Henry Mai <[email protected]> Co-authored-by: ankita.yadav <[email protected]> Co-authored-by: kparwal <[email protected]> Co-authored-by: nauy2697 <[email protected]> Co-authored-by: ykrystal <[email protected]> Co-authored-by: ankita-yadav12 <[email protected]> Co-authored-by: Shiva Chinnam <[email protected]> Co-authored-by: feroztrianz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve error message with invalid spill bucket
Issue #, if available:
#415
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.