Add support for string array request parameter to endpoint resolution #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 68.81% 69.57% +0.76%
==========================================
Files 10 10
Lines 2751 2797 +46
==========================================
+ Hits 1893 1946 +53
+ Misses 858 851 -7 ☔ View full report in Codecov by Sentry. |
graebm
approved these changes
Aug 1, 2024
TingDaoK
reviewed
Aug 2, 2024
| case AWS_ENDPOINTS_PARAMETER_STRING_ARRAY: | ||
| val->value = value->default_value; | ||
| val->value.is_ref = true; | ||
| break; |
There was a problem hiding this comment.
two break
Suggested change
| break; | |
There was a problem hiding this comment.
this one has been merged, but i addressed it in #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.