enable conversion error

awslabs · Jul 3, 2024 · 47a6cbc · 47a6cbc
1 parent 33f7b72
commit 47a6cbc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/include/aws/crt/Variant.h b/include/aws/crt/Variant.h
@@ -148,14 +148,14 @@ namespace Aws
             {
                 AWS_FATAL_ASSERT(other.m_index != -1);
                 m_index = other.m_index;
-                VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, other, CopyMoveConstructor());
+                VisitorUtil<0, Ts...>::VisitBinary(this, other, CopyMoveConstructor());
             }
 
             Variant(Variant &&other)
             {
                 AWS_FATAL_ASSERT(other.m_index != -1);
                 m_index = other.m_index;
-                VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, std::move(other), CopyMoveConstructor());
+                VisitorUtil<0, Ts...>::VisitBinary(this, std::move(other), CopyMoveConstructor());
             }
 
             template <typename T, EnableIfOtherIsThisVariantAlternative<T> = 1> Variant(const T &val)
@@ -213,11 +213,11 @@ namespace Aws
                     {
                         Destroy();
                         m_index = other.m_index;
-                        VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, other, CopyMoveConstructor());
+                        VisitorUtil<0, Ts...>::VisitBinary(this, other, CopyMoveConstructor());
                     }
                     else
                     {
-                        VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, other, CopyMoveAssigner());
+                        VisitorUtil<0, Ts...>::VisitBinary(this, other, CopyMoveAssigner());
                     }
                 }
                 return *this;
@@ -232,11 +232,11 @@ namespace Aws
                     {
                         Destroy();
                         m_index = other.m_index;
-                        VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, std::move(other), CopyMoveConstructor());
+                        VisitorUtil<0, Ts...>::VisitBinary(this, std::move(other), CopyMoveConstructor());
                     }
                     else
                     {
-                        VisitorUtil<(Variant::IndexT)0, Ts...>::VisitBinary(this, std::move(other), CopyMoveAssigner());
+                        VisitorUtil<0, Ts...>::VisitBinary(this, std::move(other), CopyMoveAssigner());
                     };
                 }
                 return *this;
@@ -386,7 +386,7 @@ namespace Aws
 
             template <typename VisitorT> void Visit(VisitorT &&visitor)
             {
-                return VisitorUtil<(Variant::IndexT)0, Ts...>::Visit(this, std::forward<VisitorT>(visitor));
+                return VisitorUtil<0, Ts...>::Visit(this, std::forward<VisitorT>(visitor));
             }
 
           private:
@@ -473,7 +473,7 @@ namespace Aws
                     }
                     else
                     {
-                        VisitorUtil<Index + (IndexT)1, Second, Rest...>::Visit(pThis, std::forward<VisitorStruct>(visitor));
+                        VisitorUtil<Index + 1, Second, Rest...>::Visit(pThis, std::forward<VisitorStruct>(visitor));
                     }
                 }
 
@@ -490,7 +490,7 @@ namespace Aws
                     }
                     else
                     {
-                        VisitorUtil<Index + (IndexT)1, Second, Rest...>::VisitBinary(
+                        VisitorUtil<Index + 1, Second, Rest...>::VisitBinary(
                             pThis, std::forward<Variant<Ts...>>(other), std::forward<VisitorStruct>(visitor));
                     }
                 }
@@ -509,7 +509,7 @@ namespace Aws
                     }
                     else
                     {
-                        VisitorUtil<Index + (IndexT)1, Second, Rest...>::VisitBinary(
+                        VisitorUtil<Index + 1, Second, Rest...>::VisitBinary(
                             pThis, other, std::forward<VisitorStruct>(visitor));
                     }
                 }

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -286,7 +286,7 @@ if(AWS_WARNINGS_ARE_ERRORS)
     if(MSVC)
         target_compile_options(${TEST_BINARY_NAME} PRIVATE /W4 /WX /wd4068)
     else()
-        target_compile_options(${TEST_BINARY_NAME} PRIVATE -Wall -Wno-long-long -Werror)
+        target_compile_options(${TEST_BINARY_NAME} PRIVATE -Wall -Wno-long-long -Werror -Wconversion)
     endif()
 endif()