cbor binding #627
Merged
cbor binding #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/aws/crt/cbor/Cbor.h
Outdated
| IndefMapStart = AWS_CBOR_TYPE_INDEF_MAP_START, | ||
| }; | ||
|
|
||
| class AWS_CRT_CPP_API CborEncoder |
There was a problem hiding this comment.
add final if destructor is not virtual
SergeyRyabinin
approved these changes
Jun 14, 2024
graebm
reviewed
Jun 19, 2024
| *****************************************************/ | ||
| CborEncoder::CborEncoder(Crt::Allocator *allocator) noexcept | ||
| { | ||
| m_encoder = aws_cbor_encoder_new(allocator); |
There was a problem hiding this comment.
there's no possible way that aws_cbor_encoder_new() or aws_cbor_decoder_new() could ever return NULL in the future, right? right?
if so, we won't want to use normal C++ constructors, because they can't fail without the use of exceptions, which we turn off
There was a problem hiding this comment.
I don't think we will error let the new function fail for the encoder and decoder, besides of allocation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bare minimal binding for cbor
follow up:
std::chrono::system_clock::time_point?We will need those follow up for sure, but debatable about where they should live, maybe in C++ SDK? Or maybe in crt-ccp, we should hold for the follow-ups until C++ SDK picks up the integration job
Won't merge until the C code merge to main and the follow up has been addressedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.