Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
At configuration time,
s2n-tls
performs a number of feature probes against libcrypto in order to configure itself. In the current implementation of aws-crt-cpp build system, the correct libcrypto does not yet exist (nor are aws-lc's headers visible to the feature check, for that matter). This results in a misconfigured s2n-tls.Unfortunately, there is no easy way to change
s2n-tls
to be configured at build time, because CMake standard functionality for this (try_compile
function) can be used only at configuration time.Description of changes:
Build and install
aws-lc
into a build directory at configuration time, so libcrypto can be used bys2n-tls
.This PR depends on awslabs/aws-c-common#1144 and awslabs/aws-c-cal#197
The changed behavior can be examined in the
linux-compat (al2-x64)
CI job.Prior to this PR, s2n-tls feature probes looked like this
Now s2n feature probes look like this
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.