Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MSVC most vexing parse #659

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix MSVC most vexing parse #659

merged 1 commit into from
Aug 29, 2024

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Currently CI is failing mainline on msvc with

D:\a\work\aws-crt-cpp\include\aws\crt\StringView.h(861,51): error C2760: syntax error: '>' was unexpected here; expected 'declaration' [D:\a\work\aws-crt-cpp\build\aws-crt-cpp\aws-crt-cpp-header-check-cxx20.vcxproj]
  (compiling source file '../../header-checker-cxx20/headerchecker_aws_crt_Api_h.cpp')

fixes most vexing parse by adding braced init + include string directly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sbiscigl sbiscigl merged commit a2cb2c5 into main Aug 29, 2024
59 checks passed
@sbiscigl sbiscigl deleted the test-main branch August 29, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants