stop building s2n via aws_prebuild_dependency() #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
aws-sdk-cpp could no longer cross-compile for Android, after we switched to building S2N via aws_prebuild_dependency() in this PR: #665
Description of changes:
Go back to building s2n via CMake's
add_subdirectory(). This does a better job picking up misc CMake settings (like toolchains for cross-compilation) thanaws_prebuild_dependency()We'll continue building AWS-LC via
aws_prebuild_dependency()for now, since we still needlibcryptofully built before S2N's configure stage. But that won't be a problem foraws-sdk-cppwhich always passes-DUSE_OPENSSL=ONto skip building AWS-LC and use the system's pre-existing libcrypto instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.