non-required for now

awslabs · Jun 21, 2024 · 814ea9d · 814ea9d
1 parent c60d2e9
commit 814ea9d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/crt/aws-c-s3 b/crt/aws-c-s3
diff --git a/src/main/java/software/amazon/awssdk/crt/s3/S3Client.java b/src/main/java/software/amazon/awssdk/crt/s3/S3Client.java
@@ -141,13 +141,6 @@ public S3MetaRequest makeMetaRequest(S3MetaRequestOptions options) {
             throw new IllegalArgumentException("S3Client.makeMetaRequest has invalid options; Response Handler cannot be null.");
         }
 
-        String operationName = options.getOperationName();
-        if (options.getMetaRequestType() == S3MetaRequestOptions.MetaRequestType.DEFAULT && operationName == null) {
-            Log.log(Log.LogLevel.Error, Log.LogSubject.S3Client,
-                    "S3Client.makeMetaRequest has invalid options; Operation name must be set for MetaRequestType.DEFAULT.");
-            throw new IllegalArgumentException("S3Client.makeMetaRequest has invalid options; Operation name must be set for MetaRequestType.DEFAULT.");
-        }
-
         S3MetaRequest metaRequest = new S3MetaRequest();
         S3MetaRequestResponseHandlerNativeAdapter responseHandlerNativeAdapter = new S3MetaRequestResponseHandlerNativeAdapter(
                 options.getResponseHandler());

diff --git a/src/main/java/software/amazon/awssdk/crt/s3/S3MetaRequestOptions.java b/src/main/java/software/amazon/awssdk/crt/s3/S3MetaRequestOptions.java
@@ -102,8 +102,8 @@ public MetaRequestType getMetaRequestType() {
 
     /**
      * The S3 operation name (eg: "CreateBucket"),
-     * this MUST be set for {@link MetaRequestType#DEFAULT},
-     * it is not necessary for other meta request types.
+     * this should be set for {@link MetaRequestType#DEFAULT},
+     * it is ignored for other meta request types since the operation is implicit.
      *
      * See <a href="https://docs.aws.amazon.com/AmazonS3/latest/API/API_Operations_Amazon_Simple_Storage_Service.html">
      * S3 API documentation</a> for the canonical list of names.