-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Musl testing #544
Merged
Merged
Musl testing #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm* the final baseline fallback for arm architecture detection
…he omit check pass
waahm7
reviewed
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the following changes
- Removes Alpine profile and different Surefire version, that is not needed.
- Fix musl build script to correctly mount the source and use that instead of pulling from Github.
- Keep previous cross compile jobs as they use glibc.
- Add CI and CD scripts for armv7 and armv8.
- Use Qemu from ECR. Docker has a pull limit for users, and I encountered issues during testing due to this limit. I will update the builder to keep this image up-to-date
graebm
reviewed
Jul 7, 2023
graebm
reviewed
Jul 7, 2023
Co-authored-by: Michael Graeb <[email protected]>
graebm
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove old cross-compiled arm CI in favor of the Musl-based arm jobs.Keep both as cross-compiled are used with Glibc.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.