Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl testing #544

Merged
merged 88 commits into from
Jul 11, 2023
Merged

Musl testing #544

merged 88 commits into from
Jul 11, 2023

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Oct 24, 2022

  • Add an additional native artifact directory component for C runtime
  • Add Musl detection in build (CMakeLists.txt) and at runtime
  • Add Musl-based CI; remove old cross-compiled arm CI in favor of the Musl-based arm jobs. Keep both as cross-compiled are used with Glibc.
  • Add environment/system property override for architecture selection to support ambiguous (arm6 vs arm7) cases
  • Tweak some tests to work in a Musl-based environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…rm* the final baseline fallback for arm architecture detection
Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the following changes

  • Removes Alpine profile and different Surefire version, that is not needed.
  • Fix musl build script to correctly mount the source and use that instead of pulling from Github.
  • Keep previous cross compile jobs as they use glibc.
  • Add CI and CD scripts for armv7 and armv8.
  • Use Qemu from ECR. Docker has a pull limit for users, and I encountered issues during testing due to this limit. I will update the builder to keep this image up-to-date

README.md Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
builder.json Show resolved Hide resolved
builder.json Show resolved Hide resolved
README.md Show resolved Hide resolved
codebuild/cd/alpine-arm64-build.yml Outdated Show resolved Hide resolved
@waahm7 waahm7 merged commit 83e1781 into main Jul 11, 2023
38 checks passed
@waahm7 waahm7 deleted the MuslTesting branch July 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants