Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Win Sanity Check Script #606

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update Win Sanity Check Script #606

merged 3 commits into from
Oct 21, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Oct 21, 2024

Issue #, if available:

Description of changes:

  • Update win sanity check script to not use python 37

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

TingDaoK
TingDaoK reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/awslabs/aws-crt-python/blob/main/codebuild/cd/manylinux-x86-build.yml#L11
https://github.com/awslabs/aws-crt-python/blob/main/codebuild/cd/manylinux-x64-build.yml#L11

should we update those as well?

@waahm7 waahm7 merged commit 59d7e69 into main Oct 21, 2024
64 checks passed
@waahm7 waahm7 deleted the fix-test-pypi-install branch October 21, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingDaoK TingDaoK TingDaoK left review comments

@DmitriyMusatkin DmitriyMusatkin DmitriyMusatkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waahm7 @TingDaoK @DmitriyMusatkin