Skip to content

Commit

Permalink
Remove CodeCommitRole from initial base stack (#663)
Browse files Browse the repository at this point in the history
The adf-codecommit-role-base role from the ADF CloudFormation Initial Base Stack for the Management Account in the us-east-1 region, with the trust policy being assumable from `codecommit.amazonaws.com` doesn't seem be used anywhere. I couldn't find it being used in ADF codebase, or the cloudformation template it comes in. I couldn't anything find you could do with codecommit that requires a role with `codecommit.amazonaws.com` being the trusted service principal to assume to it or even passing a role to codecommit.
  • Loading branch information
faridnsh authored Oct 31, 2023
1 parent 936c92a commit 68fad6d
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions src/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1153,39 +1153,6 @@ Resources:
RoleArn: !GetAtt AccountBootstrapStartExecutionRole.Arn
Id: CreateStackLinkedAccountV1

CodeCommitRole:
Type: AWS::IAM::Role
Properties:
RoleName: "adf-codecommit-role-base"
AssumeRolePolicyDocument:
Version: "2012-10-17"
Statement:
- Effect: Allow
Principal:
Service: codecommit.amazonaws.com
Action:
- sts:AssumeRole
Path: /

CodeCommitPolicy:
Type: AWS::IAM::Policy
Properties:
PolicyName: "adf-organizations-codecommit-role-policy"
PolicyDocument:
Version: "2012-10-17"
Statement:
- Effect: Allow
Action:
- "codecommit:BatchGetRepositories"
- "codecommit:Get*"
- "codecommit:GitPull"
- "codecommit:List*"
- "codecommit:CancelUploadArchive"
- "codecommit:UploadArchive"
Resource: "*"
Roles:
- !Ref CodeCommitRole

CodeBuildRole:
Type: AWS::IAM::Role
Properties:
Expand Down

0 comments on commit 68fad6d

Please sign in to comment.