Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccessControl on S3 Buckets #681

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add AccessControl on S3 Buckets #681

merged 2 commits into from
Jan 18, 2024

Commits on Jan 17, 2024

  1. Add AccessControl on S3 Buckets 

    **Why?**

At the moment, if there is an `AccessControl` set on the S3 Bucket (in v3.2.0
ADF had this set), you cannot remove it and move to the new
Bucket Ownership Rules.

The only option to move to the new Bucket Ownership Rules would be to add those
and remove the `AccessControl` property after. However, since we need to allow
customers to upgrade, we cannot do this in a single release.

**What?**

Added the Bucket Ownership Rules today, and keep the `AccessControl` for now.

We can remove the `AccessControl` property in a future version.
While we instruct customers to first upgrade to v4.0.0 if they need to move
to the version where this property is removed.
    @sbkok
    sbkok committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9683114 View commit details
    Browse the repository at this point in the history

  2. Disable Access Control warning until upgrade path is supported

    @sbkok
    sbkok committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6af748f View commit details
    Browse the repository at this point in the history