Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improve samples #718

Merged
merged 2 commits into from
May 13, 2024
Merged

Feat: Improve samples #718

merged 2 commits into from
May 13, 2024

Commits on May 13, 2024

  1. Feat: Improve samples

    **Why?**
    
    These changes aim to improve the overall quality, maintainability, and
    usability of the ADF sample templates, while also providing better
    documentation and aligning with the latest AWS best practices.
    
    - To adhere to best practices and improve maintainability of the code base.
    - To enhance security and observability by enabling VPC Flow Logs.
    - To address code style issues and enforce consistent formatting.
    
    **What?**
    
    - Specified explicit files to include in the CodeBuild output artifacts.
    - Improvements to the VPC example:
          - Added support for enabling VPC Flow Logs to S3 or CloudWatch Logs.
          - Refactored resource ordering and added conditions for better readability.
          - Exported additional VPC CIDR range output for convenience.
    - Fixed minor documentation issues in sample guides.
    - Update README files with additional details, prerequisites, and deployment
       instructions for various samples.
    - Upgrade the `sample-fargate-node-app` to use the AWS public container registry
       (public.ecr.aws) instead.
    - Refactor the `sample-ec2-with-codedeploy` sample to use AWS Launch Templates,
       a newer and recommended approach instead of Launch Configurations.
    - Update `sample-ec2-with-codedeploy` scripts to install newer versions of
       Amazon Linux 2023, Java, and other dependencies. Also fixed the scripts to be
       compatible to the recommended IMDSv2 authenticated APIs.
    - Miscellaneous improvements and bug fixes across various sample templates.
    
    ---
    
    By submitting this pull request, I confirm that you can use, modify, copy, and
    redistribute this contribution, under the terms of your choice.
    sbkok authored and StewartW committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5c7eb80 View commit details
    Browse the repository at this point in the history
  2. Fix markdown table in changelog

    sbkok authored and StewartW committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4f35d46 View commit details
    Browse the repository at this point in the history