Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[US] S3NioSpiConfiguration.withCredentials(null) and withCredentials(null, null) remove credentials #131

Closed
stefanofornari opened this issue Jul 28, 2023 · 0 comments
Closed

[US] S3NioSpiConfiguration.withCredentials(null) and withCredentials(null, null) remove credentials #131

stefanofornari opened this issue Jul 28, 2023 · 0 comments

Comments

@stefanofornari
Copy link
Contributor

AS A developer
I WANT that calling withCredentials(null) and withCredentials(null, null)in S3NioSpiConfiguration all credentials information are removed
SO THAT both methods bring the same side effect
stefanofornari added a commit to stefanofornari/aws-java-nio-spi-for-s3 that referenced this issue Jul 28, 2023
@stefanofornari
- addressing issue mainstrem awslabs#131; it was already correctly im…
5316095 
…plemented, improved test

- using assertj everywhere
stefanofornari added a commit to stefanofornari/aws-java-nio-spi-for-s3 that referenced this issue Jul 28, 2023
@stefanofornari
- addressing issue mainstrem awslabs#131; it was already correctly im…
1785270 
…plemented, improved test

- using assertj everywhere
@stefanofornari stefanofornari changed the title [US] S3NioSpiConfiguration.withCredentials(null) removes credentials [US] S3NioSpiConfiguration.withCredentials(null) and withCredentials(null, null) remove credentials Jul 28, 2023
@stefanofornari stefanofornari mentioned this issue Jul 28, 2023
Merged
markjschreiber pushed a commit that referenced this issue Aug 1, 2023
@stefanofornari
- addressing issue mainstrem #131; it was already correctly implement…
b854041 
…ed, improved test (#132)

- using assertj everywhere
markjschreiber pushed a commit that referenced this issue Sep 6, 2023
@stefanofornari
Addressing issue #30 about NIO FileSystem lifecycle (#133)
88c6308 
* - addressing issue mainstrem #131; it was already correctly implemented, improved test
- using assertj everywhere

* implementing upstream #30; main changes are:
- FilsSystem lifecycle
- adding S3ClientProvider to isolate how the aws client is built

---------

Co-authored-by: sterapido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanofornari @markjschreiber