Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadoc: fix no @param (description) for <T> #240

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

guicamest
Copy link
Contributor

Description of changes:

Fix a couple of javadoc warnings:

.../aws-java-nio-spi-for-s3/src/main/java/software/amazon/nio/spi/s3/S3ClientProvider.java:139: warning: no @param for <T>
    public <T extends AwsClient> T universalClient(boolean async) {
                                   ^
.../aws-java-nio-spi-for-s3/src/main/java/software/amazon/nio/spi/s3/S3FileSystemProvider.java:587: warning: no description for @param
     * @param <V>
       ^
2 warnings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@markjschreiber
Copy link
Contributor

As you have a few PRs open I will let you merge this in the order you think is best.

@guicamest
Copy link
Contributor Author

This one can be merged asap too👍

@markjschreiber markjschreiber merged commit c6d41b7 into awslabs:main Oct 30, 2023
1 check passed
@guicamest guicamest deleted the fixjavadocwarnings branch October 30, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants