Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(revapi): Verify API/ABI compatibility during build #246

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

guicamest
Copy link
Contributor

Description of changes:

As mentioned in #223 (comment):

This PR adds the revapi gradle plugin so that API/ABI compatibility is checked during the build (more specifically during ./gradlew check). Whenever changes are introduced, the plugin verifies against the latest version (currently 1.2.4) and fails the build in case the are API/ABI incompatibilities. Breaking changes can be accepted as documented in the Contribution guide.

Since there are many breaking changes for v2, they are currently accepted in the CI build. Once v2 is released, it the check on CI build should be commented in order to guarantee a stable API/ABI.

Here is a list of breaking changes since 1.2.4: revapi.yml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@markjschreiber markjschreiber merged commit bf77c9d into awslabs:main Oct 31, 2023
1 check passed
@guicamest guicamest deleted the pluginCheckApiCompatibility branch October 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants