-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(style): Add Checkstyle plugin for Gradle #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in a style checker! A couple of comments.
|
||
/** | ||
* Demo class that will read text from S3 URIs that you provide on the command line. Your standard AWS credential chain | ||
* is used for permissions. | ||
*/ | ||
public class Main { | ||
|
||
private static final Logger logger = LoggerFactory.getLogger(ListPrefix.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the Main.class
logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 🥳
…eSystemInfo, TimeOutUtils
ec7b787
to
b211c70
Compare
cannot use hashCode
b211c70
to
7299fc4
Compare
Issue #300
Description of changes:
This PR adds Checkstyle as part of the build process. The configuration is based on Checkstyle for AWS SDK V2, without some custom checks on for that specific project.
During
./gradlew build
, the following tasks are executed:For the test sources only the
header
check is applied.Given that style is now enforced during build time, many files are formatted / updated 😬 .
TODO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.