chore(S3BasicFileAttributes): Do IO in methods that throw IOException
#342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The implementation of S3BasicFileAttributes does IO whenever
size()
,lastModified()
orfileKey()
are invoked. When there are network problems,RuntimeException
s are thrown, since theBasicFileAttributes
nio interface does not declare any expected exceptions to be thrown when calling these methods.In order to conform better with the contract specified by the nio interfaces, the IO done in
size()
,lastModified()
andfileKey()
methods is now done before constructing the attributes: whenreadAttributes
from the provider or the attributeview is called.readAttributes
in those interfaces specify that it can throwIOException
and therefore seems a better place where to do the IO to get the object metadata.As a side effect, requests to S3 are reduced whenever a user of a library needs more than 1 attribute of a file; for example
size
andlastModified
.References:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.