Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Exclude unused apache client dependency #412

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

guicamest
Copy link
Contributor

*Issue #109

Description of changes:
s3 and s3-transfer-manager depend on apache-client dependency. Given that there is no use of a synchronous s3 client currently in the project, this dependency is not necessary at the moment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guicamest guicamest changed the title chore: Remove unused apache client dependency chore: Exclude unused apache client dependency Mar 17, 2024
Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@markjschreiber
Copy link
Contributor

closes #109

@markjschreiber markjschreiber merged commit d3af286 into awslabs:main Mar 18, 2024
1 check passed
@guicamest guicamest deleted the issue_109 branch March 18, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants