fix: improve speed of Files.walk()
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
force-pushed
the
markjschreiber/feat/client-cache
branch
from
8b6f45c
to
88c83bb
Compare
|
fixes #458 |
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
Aug 6, 2024
* feature: cache s3 clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#458
Description of changes:
caches results of expensive calls to determine the bucket region and caches clients for buckets to reduce the large expense of creating a client. Clients are meant to be re-used according to SDK docs and are thread safe. Because clients can be "auto-closed", Cached clients are wrapped so that their "closed" status can be recorded and queried. Generally clients should not be closed unless you know you will no longer need them (due to the cost of creating them).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.