fix: Let getFileAttributeView() return null for unsupported view class. #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No issue created this time. If needed, I can create one later.
Description of changes:
Observed when trying to use JDK's
Files.move()
method. This method uses thejava.nio.file.CopyMoveHelper#copyToForeignTarget
method. The implementation tries to get thePosixFileAttributeView
(in line 109). This fails for the S3 implementation with anUnsupportedOperationException
, which is not caught by JDK's code, resulting in the move operation to fail.Having read the method description, I'm of the opinion that the method should return
null
in case of an unsupported view type. This would at least be compliant with the method comment in thecopyToForeignTarget
method (line 108):I've adapted the test accordingly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.